storage: problematic dependency resolution with `stats`

[StephenWithPH]

Having upgraded from:

cloud.google.com/go/storage v1.46.0 -> cloud.google.com/go/storage v1.48.0, I get the following error:

<redacted>/go/pkg/mod/cloud.google.com/go/storage@v1.48.0/storage.go:264:25: undefined: stats.NewMetrics

This corresponds to:

google-cloud-go/storage/storage.go

Line 264 in d95c86d

Metrics: stats.NewMetrics("grpc.client.attempt.duration"),

... and I believe these two imports are in conflict:

google-cloud-go/storage/storage.go

Lines 56 to 57 in d95c86d

	"google.golang.org/grpc/experimental/stats"
	"google.golang.org/grpc/stats/opentelemetry"

google-cloud-go/storage/go.mod

Lines 26 to 27 in d95c86d

	google.golang.org/grpc v1.67.2
	google.golang.org/grpc/stats/opentelemetry v0.0.0-20240907200651-3ffb98b2c93a

I suspect that somehow, this NewMetrics is getting shadowed by https://pkg.go.dev/google.golang.org/grpc/stats/opentelemetry@v0.0.0-20241028142157-ada6787961b3 .

For a brief period, I was getting ambiguous import errors pointing at these two packages with go mod tidy. I'm no longer getting those errors, but I still fail to compile.

[davidh16]

same issue here

[SadriShehu]

Facing the same issue as well.

[fasmat]

The problem is that google.golang.org/grpc/stats/opentelemetry is not its own module any more. This was changed between v1.68.1 and v1.69.0 of google.golang.org/grpc: grpc/grpc-go#7759

Upgrading to the latest google.golang.org/grpc package will now cause the same package to be imported from two different sources. Upgrading storage to use the latest google.golang.org/grpc and dropping the google.golang.org/grpc/stats/opentelemetry dependency should fix the issue.

[nikolaydubina]

same issue here. direct removal google.golang.org/grpc/stats/opentelemetry v0.0.0-20241028142157-ada6787961b3 // indirect from go.mod, makes build to fail

something has to be changed in cloud.google.com/go module

[fasmat]

I created a PR to update the GRPC dependency in all modules: #11284

[nikolaydubina]

I mean, that change is huge. not sure can be accepted

need someone from google to fix this

[fasmat]

Depends, the amount of code changed is minimal (I believe just a singe line of code). The rest is just replacing the current version of the dependency with the newest one and bumping Go everywhere where it's still 1.21 to 1.22 🙂 The new grpc dependency requires at least 1.22.

[nikolaydubina]

ok, updating everything and keeping cloud.google.com/go/storage v1.46.0 worked for me. will check back on this once google replies.

[dfawley]

I believe the only (?) issue here is that grpc-go moved some of the symbols that cloud storage was relying upon from our experimental directory into a stable location, without leaving behind type aliases. If so, that's our mistake and we will fix it ASAP. PR grpc/grpc-go#7929 should address it, and we will do a patch release with it ASAP.