chore: update hermetic library generation workflow #10693
There are no files selected for viewing
|
There was a problem hiding this comment. Can you remind me what this file is used for? There was a problem hiding this comment. This workflow is used to verify generated files, e.g., There was a problem hiding this comment. What if we do want to update There was a problem hiding this comment.
The check will fail. This is a not required check only to remain the author the change is indeed intentional.
root pom and gapic-libraries-bom are generated through hermetic build cli script (just like repo-level post processing). Other checks are done through shell script in this repo, which are not generating any java file, so they are relatively fast. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,42 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # GitHub action job to test core java library features on | ||
| # downstream client libraries before they are released. | ||
| name: Hermetic library generation upon generation config change through pull requests | ||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "generation_config.yaml" | ||
|
There was a problem hiding this comment. Is the trigger only for main branch? If yes, can this be configured to be triggered for other branches, like a future LTS branch? There was a problem hiding this comment. This can be triggered when a pull request changes Therefore, it can be used in any branch since the pull request is not necessarily based on There was a problem hiding this comment. I don't see any configuration for a target branch, does it mean if I create a PR with |
||
|
|
||
| jobs: | ||
| library_generation: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| library_generation_image_tag: 2.39.0 | ||
|
There was a problem hiding this comment. Is this configured to be updated renovate bot? There was a problem hiding this comment. I plan to update renovate config in separate PR. |
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Generate changed libraries | ||
| shell: bash | ||
| run: | | ||
| set -x | ||
| [ -z "$(git config user.email)" ] && git config --global user.email "[email protected]" | ||
| [ -z "$(git config user.name)" ] && git config --global user.name "cloud-java-bot" | ||
| bash generation/hermetic_library_generation.sh \ | ||
| --target_branch ${{ github.base_ref }} \ | ||
| --current_branch ${{ github.head_ref }} \ | ||
| --image_tag "${library_generation_image_tag}" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # GitHub action job to test core java library features on | ||
| # downstream client libraries before they are released. | ||
| name: Update googleapis commit | ||
| on: | ||
| schedule: | ||
| - cron: '* 2 * * *' | ||
| workflow_dispatch: | ||
|
|
||
|
|
||
| jobs: | ||
| update-googleapis-commit: | ||
| runs-on: ubuntu-22.04 | ||
| env: | ||
| # the branch into which the pull request is merged | ||
| base_branch: lts-11 | ||
|
There was a problem hiding this comment. Is this There was a problem hiding this comment. No, this is a test value. I changed it to |
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Update googleapis commit to latest | ||
| shell: bash | ||
| run: | | ||
| set -x | ||
| [ -z "$(git config user.email)" ] && git config --global user.email "[email protected]" | ||
| [ -z "$(git config user.name)" ] && git config --global user.name "cloud-java-bot" | ||
| bash generation/update_googleapis_commit.sh \ | ||
| --base_branch "${base_branch}"\ | ||
| --repo ${{ github.repository }} | ||
| env: | ||
| GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (maybe not in scope): What's the purpose of this script? Maybe a one-liner comment can help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a one-liner comment in each job in the workflow.