Skip to content

Handle missing nanos. #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2016
Merged

Handle missing nanos. #2696

merged 1 commit into from
Nov 7, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 6, 2016

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2016
@daspecster
Copy link
Contributor

This LGTM but I imagine you'll want @tseaver to look at it as well.

tseaver
tseaver approved these changes Nov 7, 2016
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to sea a rational analysis on the believed/claimed cost savings for the .0 bytes vs. all the induced cache-miss stuff on both client and server side. I would certainly be vetoing such pseudo-optimizations without real evidence if it were up to me.

@dhermes dhermes merged commit 9c68fdf into googleapis:master Nov 7, 2016
@dhermes dhermes deleted the nanos-tweak branch November 7, 2016 18:56
@dhermes
Copy link
Contributor Author

dhermes commented Nov 7, 2016

I doubt there is a single person or team responsible.

@dhermes dhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2696 from dhermes/nanos-tweak
e660443 
Handle missing nanos.
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@nnegrey @gguuss @busunkim96
dialogflow: use unique names for all resources for tests to avoid col…
20e5468 
…… [(#2696)](GoogleCloudPlatform/python-docs-samples#2696)

* dialogflow: use unique names for all resources for tests to avoid collision

* lint: line length

* break up knowledge base tests and document tests from one file into individual tests

* lint

* bump library version

* ping googleapis-common-protos to avoid release breakage

* Update requirements.txt

Co-authored-by: Gus Class <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees

@tseaver tseaver

Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @daspecster @tseaver @googlebot