test: Updates for Dual Region and testing #1340
Conversation
sydney-munro
added
the
kokoro:force-run
product-auto-label
bot
added
the
api: storage
yoshi-kokoro
removed
the
kokoro:force-run
sydney-munro
force-pushed
the
dual-region
branch
from
6805955 to
d640067
Compare
| @@ -1731,7 +1731,7 @@ public Long getMetageneration() { | |||
|
|
|||
| /** | |||
| * Returns the bucket's location. Data for blobs in the bucket resides in physical storage within | |||
| * this region. | |||
| * this region or regions. | |||
| * | |||
| * @see <a href="https://cloud.google.com/storage/docs/bucket-locations">Bucket Locations</a> | |||
There was a problem hiding this comment.
Does dual-region have a link that we can direct folks to our is it just the bucket-locations doc?
cc: @danielbankhead
There was a problem hiding this comment.
That will be here: https://cloud.google.com/storage/docs/locations
(the updates are currently in staging, pending for release)
There was a problem hiding this comment.
it appears the link https://cloud.google.com/storage/docs/bucket-locations redirects to https://cloud.google.com/storage/docs/locations I can update this link.
although it is baked in quite a few places. I will open another PR after this to update docs references to the new location page.
There was a problem hiding this comment.
Found this doc (published yesterday) feel free to use in a future PR or in the change log/release notes: https://cloud.google.com/storage/docs/dual-regions
|
LGTM, may want another Java expert to review. Then, we'll merge once googleapis/python-storage#748 is unblocked |
danielbankhead
added
the
do not merge
sydney-munro
removed
the
do not merge
Fixes #1304 ☕️
If you write sample code, please follow the samples format.