Skip to content

fix: cancel intermediate upload response bodies#1555

Open
IgorGanapolsky wants to merge 1 commit intogoogleapis:mainfrom
IgorGanapolsky:codex/deno-upload-response-body-leak
Open

fix: cancel intermediate upload response bodies#1555
IgorGanapolsky wants to merge 1 commit intogoogleapis:mainfrom
IgorGanapolsky:codex/deno-upload-response-body-leak

Conversation

@IgorGanapolsky
Copy link
Copy Markdown

Fixes #1278.

What changed

  • Cancel intermediate resumable-upload response bodies when the upload status is active.
  • Apply the same cleanup to Blob uploads and Node path uploads.
  • Add uploader unit coverage that verifies intermediate active responses are cancelled while the final response remains available for JSON parsing.

Verification

  • npm run lint -- src/cross/_cross_uploader.ts src/node/_node_uploader.ts test/unit/node/node_upload_test.ts
  • npx jasmine dist/test/unit/node/node_upload_test.js --filter='Node uploader'

Notes

  • I also ran npm audit --audit-level=high --omit=dev; the existing dependency tree reports unrelated high/critical advisories (minimatch, protobufjs). This PR is intentionally scoped to the Deno leaked response body issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant