Skip to content

Conversation

@noahdietz
Copy link
Contributor

We should prefer to run tests in parallel when they can be.

Based on #3462 (comment).

@noahdietz noahdietz requested a review from a team as a code owner January 7, 2026 00:09
@noahdietz noahdietz requested a review from julieqiu January 7, 2026 00:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Go style guide by adding a new section that encourages and provides instructions for running tests in parallel. It aims to improve testing efficiency by guiding developers on how to use t.Parallel() effectively, while also clearly defining the types of tests that should not be parallelized to avoid race conditions or incorrect behavior.

Highlights

  • Parallel Test Guidance: Added a new section to the Go style guide (doc/howwewritego.md) providing explicit guidance on configuring tests to run in parallel using t.Parallel().
  • Parallel Test Limitations: Included important caveats for parallel testing, specifically noting that tests mutating global state or using t.Chdir() are not suitable for parallel execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@noahdietz noahdietz enabled auto-merge (squash) January 7, 2026 00:09
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds valuable guidance on running Go tests in parallel to howwewritego.md. My review focuses on enhancing this new section to be more comprehensive by including a code example that demonstrates a common pattern and highlights a critical pitfall to avoid when writing parallel table-driven tests.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (99bff58) to head (2d77f3d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3476   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         167      167           
  Lines       13823    13823           
=======================================
  Hits        11206    11206           
  Misses       2034     2034           
  Partials      583      583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noahdietz noahdietz requested a review from julieqiu January 7, 2026 17:44
Copy link
Member

@julieqiu julieqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@noahdietz noahdietz requested a review from julieqiu January 7, 2026 18:14
@noahdietz noahdietz merged commit 7322ae4 into googleapis:main Jan 7, 2026
10 checks passed
@noahdietz noahdietz deleted the test-parallel branch January 7, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants