feat: Initial timed stream implementation for application latencies #1639
+148
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
danieljbruce
commented
Jul 10, 2025
| const totalMilliseconds = timedStream.getTotalDurationMs(); | ||
| console.log(totalMilliseconds); | ||
| // totalMilliseconds should be around 10 seconds, 1 per row | ||
| assert(totalMilliseconds > 9000); |
There was a problem hiding this comment.
When you check out this code locally this assert fails which is a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a timed stream object. The intent of this PR is to decide on an implementation for the timed stream so that the timed stream can then be used as a tool for measuring application latencies. Tests should accurately reflect what the timed stream should and should not do.
Impact
Basically provides the right plumbing for application latencies measurement. Also allows the team to have a medium where we can do test driven development and discuss and agree on what requirements for application latencies should be met.
Testing
Unit tests for the timed stream are added to illustrate what the timed stream should do. This ensures the measurements captured by the timed stream will meet the needs required in order to measure application latencies.