Adding support for "mergeFields" #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mergefields
branch
from
e8940f3 to
68981ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1745 1802 +57
=====================================
+ Hits 1745 1802 +57
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
mergefields
branch
from
68981ba to
4f722ac
Compare
gsoltis
suggested changes
Apr 6, 2018
| const remainingPaths = this._sortedPaths.slice(0); | ||
|
|
||
| const processObject = (currentData, currentPath) => { | ||
| let result = null; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
schmidt-sebastian
force-pushed
the
mergefields
branch
from
eac2037 to
f1eaf51
Compare
gsoltis
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for "mergeFields".
We also now support 100% of all conformance tests. A fair number of changes in this PR is geared to make these tests pass - including not sending any data to the backend that is excluded via a field mask.