Adding Watch conformance tests #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt-watchconformance
branch
2 times, most recently
from
cc6c3a6 to
e7a6db5
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1802 1802
=====================================
Hits 1802 1802
Continue to review full report at Codecov.
|
schmidt-sebastian
force-pushed
the
mrschmidt-watchconformance
branch
from
a8194ee to
68c7034
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-watchconformance
branch
from
68c7034 to
8184303
Compare
gsoltis
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the Watch conformance tests from https://github.com/GoogleCloudPlatform/google-cloud-common/pull/252
The test uses 0x1 as its Watch Target ID. Instead of rewriting this, I changed Node to also use 0x1, as the actual target ID that we use doesn't really matter.