fix: correctly escape field paths with multiple backslashes or backticks #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: s
albertnis
force-pushed
the
fix-escape
branch
from
fd0ae98 to
760848a
Compare
Previously, only the first backslash and backtick was being escaped. This broke `update` and `set (merge)` calls when a field path contained multiple backslashes. `replaceAll` is an alternative here, but I think a global regex has better compatibility with older versions of Node.
albertnis
force-pushed
the
fix-escape
branch
from
760848a to
2b4e42d
Compare
dconeybe
approved these changes
Dec 13, 2024
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
Thanks for the fix, and the updated unit tests!
dconeybe
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
changed the base branch from
main
to
community/albertnis/fix-escape
MarkDuckworth
merged commit b8cbf9a
into
googleapis:community/albertnis/fix-escape
13 checks passed
dconeybe
pushed a commit
that referenced
this pull request
Dec 17, 2024
…cks (#2259) (#2261) Co-authored-by: Albert Nisbet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the first backslash and backtick was being escaped. This broke
updateandset (merge)calls when a field path contained multiple backslashes.replaceAllis an alternative here, but I think a global regex has better compatibility with older versions of Node.Fixes #2019 🦕