Skip to content

Conversation

@Gautam04
Copy link
Contributor

Adding a new span attribute called gcp.resource.name which contains an identifier to a particular firestore database in the following format:

//firestore.googleapis.com/projects/{project}/databases/{database_id}

Example:

//firestore.googleapis.com/projects/my_project/databases/(default)

@Gautam04 Gautam04 requested review from a team as code owners November 30, 2025 15:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Nov 30, 2025
@dconeybe
Copy link
Contributor

dconeybe commented Dec 1, 2025

Googlers see b/437960147 and g/firestore-sdk-team/c/uvdOjkrQ2Ns/m/1wJrFyFdAwAJ for some background details

@MarkDuckworth
Copy link
Contributor

It seems like this one is missing a test. Perhaps update

function expectSpanHierarchy(...spanNamesHierarchy: string[]): void {
.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Dec 14, 2025
@Gautam04
Copy link
Contributor Author

It seems like this one is missing a test. Perhaps update

function expectSpanHierarchy(...spanNamesHierarchy: string[]): void {

.

Have updated tests. Please check.

@Gautam04
Copy link
Contributor Author

@MarkDuckworth @wu-hui
Could you please review this PR?

@MarkDuckworth MarkDuckworth added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2025
@MarkDuckworth MarkDuckworth added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2025
@MarkDuckworth MarkDuckworth merged commit bc0c73d into googleapis:main Dec 22, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants