Skip to content

Conversation

@schmidt-sebastian
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2017
@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1547   1547           
=====================================
  Hits         1547   1547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3f626...f0d7a62. Read the comment docs.

@stephenplusplus
Copy link
Contributor

I believe you need to update the version to match in samples/package.json (

"@google-cloud/firestore": "0.8.2"
)

@schmidt-sebastian
Copy link
Contributor Author

I believe you need to update the version to match in samples/package.json (

nodejs-firestore/samples/package.json
Line 16 in 3e3f626
"@google-cloud/firestore": "0.8.2"
)

Interesting, haven't done that before.

@schmidt-sebastian schmidt-sebastian removed their assignment Nov 16, 2017
@stephenplusplus
Copy link
Contributor

Yeah, it's something we realized we needed to do somewhat recently. Otherwise, the sample tests will only execute against that pinned version, and we won't know if newer changes break the samples.

@schmidt-sebastian schmidt-sebastian merged commit 6c1d55c into master Nov 16, 2017
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2017
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-3 branch January 30, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants