perf: Add warning when using synthetic ordering on large table. #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBergeron
added
the
do not merge
tswast
reviewed
Mar 21, 2025
| @@ -449,6 +450,20 @@ def read_gbq_table( | |||
| # if we don't have a unique index, we order by row hash if we are in strict mode | |||
| if self._force_total_order: | |||
| if not primary_key: | |||
| # 5gb chosen rather arbitrarily, mostly want to avoid warning for very small tables, for which the | |||
| # price is trivial | |||
| if (table.num_bytes or 0) > 5000000000: | |||
There was a problem hiding this comment.
Nit: Might be good to do a constant here or at least use _ as a 0 separator.
Suggested change
| if (table.num_bytes or 0) > 5000000000: | |
| if (table.num_bytes or 0) > 5_000_000_000: |
tswast
approved these changes
Mar 21, 2025
product-auto-label
bot
added
size: s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕