-
Notifications
You must be signed in to change notification settings - Fork 49
docs: deprecate bpd.options.bigquery.allow_large_results
in favor of bpd.options.compute.allow_large_results
#1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
a9a6354
f7949fa
cf9b81c
5ee146f
a0eeddf
846ab61
eae77ae
b3a9b47
1387c3b
7f18f9a
b19ce61
6977323
0b3b13b
94c308e
cf23136
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -112,7 +112,7 @@ def execute( | |||||||||||
max_results: Optional[int] = None, | ||||||||||||
) -> executor.ExecuteResult: | ||||||||||||
if use_explicit_destination is None: | ||||||||||||
use_explicit_destination = bigframes.options.bigquery.allow_large_results | ||||||||||||
use_explicit_destination = bigframes.options.compute.allow_large_results | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to use the bigquery option if the compute option is not set.
Suggested change
Since this is going to be used in many places, please make a helper function somewhere in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added one in Options class, but I'm not sure if that's the best place for it. |
||||||||||||
|
||||||||||||
if bigframes.options.compute.enable_multi_query_execution: | ||||||||||||
self._simplify_with_caching(array_value) | ||||||||||||
|
@@ -231,7 +231,7 @@ def peek( | |||||||||||
msg = bfe.format_message("Peeking this value cannot be done efficiently.") | ||||||||||||
warnings.warn(msg) | ||||||||||||
if use_explicit_destination is None: | ||||||||||||
use_explicit_destination = bigframes.options.bigquery.allow_large_results | ||||||||||||
use_explicit_destination = bigframes.options.compute.allow_large_results | ||||||||||||
|
||||||||||||
destination_table = ( | ||||||||||||
self.storage_manager.create_temp_table( | ||||||||||||
|
@@ -555,7 +555,7 @@ def iterator_supplier(): | |||||||||||
"The query result size has exceeded 10 GB. In BigFrames 2.0 and " | ||||||||||||
"later, you might need to manually set `allow_large_results=True` in " | ||||||||||||
"the IO method or adjust the BigFrames option: " | ||||||||||||
"`bigframes.options.bigquery.allow_large_results=True`." | ||||||||||||
"`bigframes.options.compute.allow_large_results=True`." | ||||||||||||
) | ||||||||||||
warnings.warn(msg, FutureWarning) | ||||||||||||
# Runs strict validations to ensure internal type predictions and ibis are completely in sync | ||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import bigframes._config.compute_options as compute_options | ||
|
||
|
||
def test_default_options(): | ||
options = compute_options.ComputeOptions() | ||
|
||
assert options.allow_large_results is False | ||
Genesis929 marked this conversation as resolved.
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.