chore: fix AttributeError when rowiterator has no attribute in g3 #1709
Conversation
product-auto-label
bot
added
the
api: bigquery
bigframes/session/metrics.py
Outdated
| if (row_iterator.total_bytes_processed is None) or ( | ||
| row_iterator.query is None | ||
| if ( | ||
| not hasattr(row_iterator, "total_bytes_processed") |
There was a problem hiding this comment.
When was this attribute added? It seems to me this isn't just a "chore: " but a true bug fix for being incompatible with older google-cloud-bigquery library.
Please add a unit test and make sure it fails on at least one nox session before this fix is added.
There was a problem hiding this comment.
Actually, the version is very old internally. I still think it'd be good to make sure we have tested against this version, but that might be too much for this PR.
There was a problem hiding this comment.
As we discussed offline, this change is not necessary for github because the setup.py asks google-cloud-bigquery>=3.31.0, but only needed for g3, which has lower version. The alternative solution would upgrade g3 version and this PR can be a short-term solution to unblock BF g3 import.
bigframes/session/metrics.py
Outdated
| if (row_iterator.total_bytes_processed is None) or ( | ||
| row_iterator.query is None | ||
| if ( | ||
| not hasattr(row_iterator, "total_bytes_processed") |
There was a problem hiding this comment.
Actually, the version is very old internally. I still think it'd be good to make sure we have tested against this version, but that might be too much for this PR.
Co-authored-by: Tim Sweña (Swast) <[email protected]>
chelsea-lin
force-pushed
the
main_chelsealin_g3merge
branch
from
bd07fec to
7c38439
Compare
product-auto-label
bot
added
size: s
chelsea-lin
force-pushed
the
main_chelsealin_g3merge
branch
from
7c38439 to
a179898
Compare
When updating BigQuery DataFrames in g3, an
AttributeErroroccurs when accessing thetotal_bytes_processedandqueryattributes of RowIterator. This is because g3 does not have an up-to-date Python client library. Here is the error message: https://screenshot.googleplex.com/4GhbZBdFZrVrCwA