-
Notifications
You must be signed in to change notification settings - Fork 61
feat: enhanced multimodal error handling with verbose mode for blob image functions #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shuoweil
wants to merge
20
commits into
main
Choose a base branch
from
shuowei-add-error-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90e7d33
to
cde2a61
Compare
32fa87c
to
623f9ba
Compare
1a873bc
to
75d69a7
Compare
This reverts commit 9a5bcd2.
75d69a7
to
53528c7
Compare
sycai
reviewed
Oct 14, 2025
check_index_type=False, | ||
engine="pillow", connection=bq_connection, verbose=verbose | ||
) | ||
if verbose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually don't put logics in unit tests: go/unit-testing-practices?polyglot=python#logic
In this case, we should use two test methods to avoid the "if-else" branch: test_blob_exif
and text_blob_exif_verbose
The same suggestion applies to other test methods too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery-dataframes API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes:
Fixes #<403365429> 🦕