Skip to content

remove old docs #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged

remove old docs #233

merged 1 commit into from
Nov 9, 2018

Conversation

max-sixty
Copy link
Contributor

Pointed out by @msegado #174 (comment)

@max-sixty max-sixty requested a review from tswast November 9, 2018 15:33
@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #233 into master will decrease coverage by 11.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #233       +/-   ##
===========================================
- Coverage   72.23%   61.05%   -11.19%     
===========================================
  Files           7        7               
  Lines         796      796               
===========================================
- Hits          575      486       -89     
- Misses        221      310       +89
Impacted Files Coverage Δ
pandas_gbq/gbq.py 65.62% <0%> (-25%) ⬇️
pandas_gbq/load.py 92.68% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b865c6...386c88d. Read the comment docs.

@max-sixty
Copy link
Contributor Author

Oh no, @codecov-io is back with its erroneous reports. Anyone have experience in disabling or fixing?

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @max-sixty and @msegado!

Regarding the fact that float doesn't work well for identifiers, I agree, but I think being consistent with Pandas is more important. People can always cast to string in their SQL if they want to preserve IDs.

@tswast tswast merged commit 1ec41b1 into googleapis:master Nov 9, 2018
@max-sixty max-sixty deleted the docs branch November 9, 2018 17:24
@msegado
Copy link

msegado commented Nov 9, 2018

Very welcome! And yes, I agree that it was a reasonable decision to match the Pandas behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants