-
Notifications
You must be signed in to change notification settings - Fork 125
chore: Issue367 get repo working with standard infrastructure #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, don't test Python 3.6
Here is the summary of changes. You are about to add 5 region tags.
You are about to delete 5 region tags.
This comment is generated by snippet-bot.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
IDK why circleci is running. I'm guessing changes are needed outside this repo. |
@jimfulton To keep the diff smaller, could we migrate the docs to our standard directory structure in a separate PR before we migrate everything else? Also, as discussed offline, we'll need at least a few tests to ensure our package works from a conda environment with conda-installed dependencies. Currently these are done manually in Circle, but I think we can move those to the noxfile with https://nox.thea.codes/en/stable/tutorial.html?highlight=conda#testing-with-conda -- That also probably warrants a separate PR before migrating to our full templates. |
Fixes #367
Nox is working at the top and in
samples
.Some unit tests fail and system tests hang, but I assume that's independent of the repo setup.
I created this by cheery-picking commits from #381, excluding the commit that checked in the result of running owlbot, so the statements above assume that owlbot is run manually.
Next steps: