Skip to content

chore: Issue367 get repo working with standard infrastructure #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

jimfulton
Copy link

@jimfulton jimfulton commented Sep 3, 2021

Fixes #367

Nox is working at the top and in samples.

Some unit tests fail and system tests hang, but I assume that's independent of the repo setup.

I created this by cheery-picking commits from #381, excluding the commit that checked in the result of running owlbot, so the statements above assume that owlbot is run manually.

Next steps:

  • @tswast review of current status
  • Check in files and changes from running owlbot
  • Get unit and system tests passing.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Sep 3, 2021
@jimfulton jimfulton requested a review from tswast September 3, 2021 14:57
@snippet-bot
Copy link

snippet-bot bot commented Sep 3, 2021

Here is the summary of changes.

You are about to add 5 region tags.
You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla
Copy link

google-cla bot commented Sep 3, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 3, 2021
@jimfulton
Copy link
Author

IDK why circleci is running. I'm guessing changes are needed outside this repo.

@tswast
Copy link
Collaborator

tswast commented Sep 7, 2021

@jimfulton To keep the diff smaller, could we migrate the docs to our standard directory structure in a separate PR before we migrate everything else?

Also, as discussed offline, we'll need at least a few tests to ensure our package works from a conda environment with conda-installed dependencies. Currently these are done manually in Circle, but I think we can move those to the noxfile with https://nox.thea.codes/en/stable/tutorial.html?highlight=conda#testing-with-conda -- That also probably warrants a separate PR before migrating to our full templates.

@tswast tswast closed this Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migration to googleapis org
2 participants