Skip to content

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Dec 3, 2025

Conformance tests were failing due to Docker API version mismatch in the kokoro's VM and docker client.

This PR pins the DOCKER_API_VERSION to 1.39

RCA for kokoro failures - https://screenshot.googleplex.com/4zsxoQ8UxqWnTky.

Error response from daemon: client version 1.52 is too new. Maximum supported API version is 1.39

@chandra-siri chandra-siri requested review from a team as code owners December 3, 2025 13:25
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Dec 3, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with debugging conformance test failures by modifying the noxfile.py. The primary change involves removing the --quiet flag from the py.test commands used to execute these tests. This ensures that the complete test output is visible, thereby providing developers with the necessary information to effectively diagnose and resolve any test-related problems.

Highlights

  • Debugging Conformance Tests: The --quiet flag has been removed from the py.test commands within the conftest_retry function in noxfile.py. This change is specifically aimed at making the output of conformance tests more verbose, which will assist in debugging failures.
  • Improved Test Visibility: By removing the --quiet flag, the full output of py.test will now be displayed when running conformance tests, providing more detailed information for diagnosing issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chandra-siri chandra-siri force-pushed the debug_conf_tests_failure branch from eabf0af to d3c3f29 Compare December 3, 2025 13:26
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the --quiet flag from the py.test command within the conftest_retry nox session. This change is likely intended to get more verbose output to debug test failures. While effective for debugging, making this a permanent change would increase CI log verbosity. My feedback suggests an alternative approach that makes verbosity configurable via an environment variable, allowing for debugging when needed without permanently altering the CI output.

@chandra-siri chandra-siri changed the title Debug conf tests failure chore: Debug conf tests failure Dec 3, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 3, 2025
@chandra-siri chandra-siri added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2025
@chandra-siri chandra-siri added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2025
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Dec 3, 2025
@chandra-siri chandra-siri changed the title chore: Debug conf tests failure chore: fix conformance test failure due to VM's API version mismatch. Dec 4, 2025
@chandra-siri
Copy link
Collaborator Author

/gcbrun

@chandra-siri chandra-siri merged commit a1c2507 into googleapis:main Dec 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants