feat: send entire object checksum in the final api call of resumable upload

[chandra-siri]

feat: send entire object checksum in the final api call of resumable upload

fixes b/461994245

[gemini-code-assist]

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the resumable upload mechanism by ensuring that the complete object checksum is consistently included in the final API request. This modification is crucial for maintaining data integrity and verifying the successful transfer of the entire object, addressing a previously identified issue.

Highlights

• Checksum Inclusion: The pull request introduces a change to include the entire object's checksum (MD5 or CRC32c) in the x-goog-hash header during the final API call of a resumable upload.
• Bug Fix: This change specifically addresses and fixes an identified bug (b/461994245) where the full object checksum was not being sent as expected.
• Unit Tests: New unit tests have been added to verify that the x-goog-hash header is correctly sent with both CRC32c and MD5 checksums for resumable uploads.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements a valuable feature by sending the entire object checksum in the final API call of a resumable upload, enhancing data integrity verification. The implementation in google/cloud/storage/_media/_upload.py is correct and well-contained. The accompanying tests in tests/unit/test_blob.py are thorough, with new test cases for both md5 and crc32c checksums. I have one suggestion to make the test code more robust.