-
Notifications
You must be signed in to change notification settings - Fork 68
feat: expose property in GrpcTransportChannel if it uses direct path. #3170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9987538
feat: expose property in GrpcTransportChannel if it uses direct path.
zhumin8 4939569
avoid exposing public abstract method.
zhumin8 14ce302
set default and test.
zhumin8 cffc483
Merge branch 'main' into fix-3134
zhumin8 6f57cb9
use is prefix instead for autovalue.
zhumin8 2e16a3b
remove unecessary create method, and use builder to construct Transpo…
zhumin8 2f29c27
Merge branch 'main' into fix-3134
zhumin8 8e5a9af
add clirr ignore rule.
zhumin8 9611d30
remove unused clirr ignore rule from gax module.
zhumin8 6cfed7b
add test for default value in newBuilder().
zhumin8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html --> | ||
<differences> | ||
<!-- Add AutoValue abstract method isDirectPath --> | ||
<difference> | ||
<differenceType>7013</differenceType> | ||
<className>com/google/api/gax/grpc/GrpcTransportChannel</className> | ||
<method>boolean isDirectPath()</method> | ||
</difference> | ||
</differences> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,8 @@ public GrpcCallContext getEmptyCallContext() { | |
/** The channel in use. */ | ||
abstract ManagedChannel getManagedChannel(); | ||
|
||
public abstract boolean isDirectPath(); | ||
|
||
public Channel getChannel() { | ||
return getManagedChannel(); | ||
} | ||
|
@@ -100,7 +102,7 @@ public void close() { | |
} | ||
|
||
public static Builder newBuilder() { | ||
return new AutoValue_GrpcTransportChannel.Builder(); | ||
return new AutoValue_GrpcTransportChannel.Builder().setDirectPath(false); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add a test case for the default value here? |
||
} | ||
|
||
public static GrpcTransportChannel create(ManagedChannel channel) { | ||
|
@@ -111,6 +113,8 @@ public static GrpcTransportChannel create(ManagedChannel channel) { | |
public abstract static class Builder { | ||
public abstract Builder setManagedChannel(ManagedChannel value); | ||
|
||
abstract Builder setDirectPath(boolean value); | ||
|
||
public abstract GrpcTransportChannel build(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/GrpcTransportChannelTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions are | ||
* met: | ||
* | ||
* * Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* * Redistributions in binary form must reproduce the above | ||
* copyright notice, this list of conditions and the following disclaimer | ||
* in the documentation and/or other materials provided with the | ||
* distribution. | ||
* * Neither the name of Google LLC nor the names of its | ||
* contributors may be used to endorse or promote products derived from | ||
* this software without specific prior written permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
package com.google.api.gax.grpc; | ||
|
||
import static org.junit.jupiter.api.Assertions.*; | ||
|
||
import io.grpc.ManagedChannel; | ||
import org.junit.jupiter.api.Test; | ||
import org.mockito.Mockito; | ||
|
||
class GrpcTransportChannelTest { | ||
|
||
@Test | ||
void testBuilderDefaults() { | ||
ManagedChannel channel = Mockito.mock(ManagedChannel.class); | ||
GrpcTransportChannel grpcTransportChannel = | ||
GrpcTransportChannel.newBuilder().setManagedChannel(channel).build(); | ||
assertFalse(grpcTransportChannel.isDirectPath()); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.