Skip to content

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Sep 30, 2021

  • Use trampoline_v2 (Docker CI Helper) for all python samples.

  • Optionally allow samples to run with a Dockerfile specified in the library repository at .kokoro/docker/samples. On a successful test run, this Dockerfile is uploaded to gcr.io/cloud-devrel-kokoro-resources/{repo-name}-samples-docker. The option is enabled by passing custom_samples_dockerfile=True to common.py_library in owlbot.py.

     templated_files = common.py_library(microgenerator=True, custom_samples_dockerfile=True)

See googleapis/python-asset#308 for an example of moving samples to to trampoline_v2.

See googleapis/python-recaptcha-enterprise#128 for an example of moving to trampoline_v2 + using a custom Dockerfile.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2021
@busunkim96 busunkim96 changed the title build: use trampoline_v2 for pythons samples and allow custom dockerfile build: use trampoline_v2 for python samples and allow custom dockerfile Oct 1, 2021
@busunkim96 busunkim96 marked this pull request as ready for review October 1, 2021 16:57
@busunkim96 busunkim96 requested a review from a team October 1, 2021 16:57
@busunkim96 busunkim96 requested a review from a team as a code owner October 1, 2021 16:57
@busunkim96 busunkim96 merged commit a7ed11e into master Oct 5, 2021
@busunkim96 busunkim96 deleted the py-samples-trampoline-v2 branch October 5, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants