Use %v instead of %s in relay logs #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change the formatting but is more consistent with our other error format strings. I also fixed the location of a string due to an unclear review comment I made.
|
I think this might have broken the postsubmit: https://github.com/googlecloudrobotics/core/actions/runs/6196097256 (happened to notice as I manually ran postsubmit for an unrelated change that failed with the same error) |
Merged
drigz
added a commit
that referenced
this pull request
Sep 15, 2023
It causes the postsubmit integration test to fail with: ``` error: Timeout occurred TEST FAILED: echo command did not run, output was "", want "hello" ``` when testing `kubectl exec`. https://source.cloud.google.com/results/invocations/8f0b86f7-c5c4-41a3-9e4c-43e325d9e1ae/targets/%2F%2Fsrc%2Fgo%2Ftests:relay_test/log - Revert "Use %v instead of %s in relay logs (#224)" - Revert "fix leaking connections when user client closes connection (#222)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change the formatting but is more consistent with our other
error format strings.
I also fixed the location of a string due to an unclear review comment I
made.