Supprt tags in sub ref directory?

[wxiaoguang]

The code says:

goreleaser-action/src/git.ts

Lines 19 to 24 in b508e2e

	if ((process.env.GITHUB_REF || '').startsWith('refs/tags')) {
	const tag = (process.env.GITHUB_REF || '').split('/').pop();
	if (tag !== '' && tag !== undefined) {
	return tag;
	}
	}

If GITHUB_REF=refs/tags/release/0.1.0, then the tag will be 0.1.0, but it should be release/0.1.0

Is the pop done by purpose? Could it support release/0.1.0 and use 0.1.0 as the version?

[caarlos0]

this whole thing should probably be removed, probably, as goreleaser itself already handles it

#370

cc/ @crazy-max

[wxiaoguang]

Thank you for your quick response.

IMO #370 is not enough. There is also a check like isTagDirty = git.isTagDirty(git.getTag())

goreleaser-action/src/main.ts

Lines 31 to 33 in b508e2e

	const commit = await git.getShortCommit();
	const tag = await git.getTag();
	const isTagDirty = await git.isTagDirty(tag);

Then, release/0.1.0 will case error No tag found for commit aabbccdd. Snapshot forced and then the --snapshot will be applied (incorrectly).

goreleaser-action/src/main.ts

Lines 49 to 53 in b508e2e

	if (isTagDirty) {
	if (!inputs.args.includes('--snapshot') && !inputs.args.includes('--nightly')) {
	core.info(`No tag found for commit ${commit}. Snapshot forced`);
	snapshot = ' --snapshot';
	}

[caarlos0]

hmm, indeed... @crazy-max probably we should remove those and bump the action to v4...

[crazy-max]

Hum I see yeah we might need a major bump.

[caarlos0]

should be fixed in #370
will release soon

[wxiaoguang]

But the bug is in

goreleaser-action/src/git.ts

Lines 19 to 24 in b508e2e

	if ((process.env.GITHUB_REF || '').startsWith('refs/tags')) {
	const tag = (process.env.GITHUB_REF || '').split('/').pop();
	if (tag !== '' && tag !== undefined) {
	return tag;
	}
	}

?

It will return an incorrect tag to tag, then isTagDirty(tag) will trigger an error inside and return true, then in if (isTagDirty) block the --snapshot will be applied to the command argument?

[caarlos0]

ah sorry, the dirty thing is still there.

[caarlos0]

#382 should fix it by removing it entirely.