uBO v1.15.20 - Icon bug causes the dashboard to freeze

[THEtomaso]

Describe the issue:

Missing icon:

Right-clicking on the missing icon and selecting "View image" results in this:

Afterwards, when going back to uBO's Dashboard, everything has frozen, and clicking on the settings tabs doesn't work anymore.

--

• OS/version: Win8.1Pro,x64
• Browser/version: Pale Moon v27.8.3,x64
• uBlock Origin version: v1.15.20 (XUL)

[gorhill]

I can reproduce image missing.

I cannot reproduce freeze with Pale Moon 27.6.0.

Edit: However I can reproduce not being able to switch panes in the dashboard. Workaround: force a reload of the dashboard.

[THEtomaso]

That's what I ment, sorry for the exaggeration.

[gorhill]

The image issue can be simply fixed by removing the leading / in the image link. I don't know why Pale Moon has a problem with this though, it is obviously able to compute the proper URL to the image, but somehow is unable to fetch at that proper URL.

The dashboard being unresponsive is unrelated to the image issue. You can reproduce the same by loading a new URL in the tab where the dashboard is and then go back using the Back button. THis might have been there since forever for all I know. If somebody can investigate/figure a fix for this quirk that would be good, I don't plan to spend time on this given this has always been there and this is the first time it is being reported.

[THEtomaso]

uBO v1.15.20 is the first version where I've seen this problem.
Which slash do you refer to by the way?
No matter which one(s) I remove, I can't get it to display the image.

--

EDIT:
Shouldn't it link to this instead?:
chrome://ublock0/content/img/icon_16.png

[gorhill]

I'm just documenting the issue, these are developer notes, you do not have to understand.

[gorhill]

I can also reproduce the dashboard unresponsiveness issue with the webext version.

[gorhill]

I will consider the unresponsive dashboard a browser issue: it happens with the Firefox/legacy and the and Firefox/webext versions of uBO. It does not happen with the Chromium version of uBO.

[THEtomaso]

SeaMonkey is also affected.
Although, it doesn't even indicate the existence of a image file at all:

--

EDIT:
OK, I see in your commit now what you ment with the leading slash.
Thanks for fixing it. :)

[gorhill]

Issue is with Firefox. If opening a remote URL in the dashboard tab, going back does not break tab navigation. This happens when I view the uBO logo however. This does not happen with Chromium.