This repository was archived by the owner on Jul 21, 2021. It is now read-only.
Allow JSON files as import from Noscript #572
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to reproduce the issue #552 I wasn't able to import the noscript settings too.
I saved the file as
noscript.json(because it really is a json file) and tried to import it.It didn't work and after some debugging I saw that the check
failed because the type was
application/json.The best way to handle this in my opinion would be to either allow
application/jsontype or disable this check.I hope you find this useful.
Regards
PS: Of course you could also tell the users to just save it as a text file :)