Skip to content

Workflow action version updates#389

Merged
jmattheis merged 2 commits into
gotify:masterfrom
cyb3rko:workflow-updates
Dec 1, 2024
Merged

Workflow action version updates#389
jmattheis merged 2 commits into
gotify:masterfrom
cyb3rko:workflow-updates

Conversation

@cyb3rko
Copy link
Copy Markdown
Contributor

@cyb3rko cyb3rko commented Nov 25, 2024

Bumping the actions to much newer versions

Comment thread .github/workflows/main.yml Outdated
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'zulu'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why zulu and not temurin?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, do you have a preference? I think temurin is more open, as it's maintained eclipse?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://whichjdk.com/, temurin sounds good

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly use Zulu or SapMachine, but only because they just work. I never bothered to change it for my projects.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then let's go with temurin, if the build succeeds (:.

@jmattheis jmattheis merged commit 69c0d04 into gotify:master Dec 1, 2024
@cyb3rko cyb3rko deleted the workflow-updates branch December 1, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants