feat: Trusted Proxies#624
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #624 +/- ##
==========================================
- Coverage 86.89% 86.81% -0.08%
==========================================
Files 44 44
Lines 1587 1593 +6
==========================================
+ Hits 1379 1383 +4
- Misses 124 125 +1
- Partials 84 85 +1 ☔ View full report in Codecov by Sentry. |
jmattheis
reviewed
Jan 21, 2024
jmattheis
reviewed
Jan 29, 2024
Gin trusts all proxies by default. This is a security problem.
jmattheis
force-pushed
the
trusted-proxies
branch
from
12ecbab to
2953d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #554
Added the option to configuration to allow trusted proxies, is handled the same way as every other
[]stringHowever, I had to find a workaround for unix sockets since there was no "official" way for Gin to handle these.
So in short if the request comes from unix socket then the
RemoteAddris set to127.0.0.1so if the user would like to trust a webserver that communicates on the socket then they would need to trust127.0.0.1via the new option.By default the RemoteAddr is set to
@on unix socket requests , however, gin only allows IP's within the trusted proxies