feat: EdDSA token for database leakage/index mitigation#971
Draft
eternal-flame-AD wants to merge 1 commit into
Draft
feat: EdDSA token for database leakage/index mitigation#971eternal-flame-AD wants to merge 1 commit into
eternal-flame-AD wants to merge 1 commit into
Conversation
a1ebdd4 to
6e5d835
Compare
6e5d835 to
131aa21
Compare
Member
|
Could you answer the questions in #966 (comment)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325 , supercedes #707
Backend should be working with tests now, I'm currently settling on a timestamp based signature scheme like TOTP with more relaxed window (+-15 minutes for now). Some early feedback would be appreciated
TODO:
also refactored some tests that used to rely on hijacking the token generation function to be consistency/property based.