fix: render selected days with selected modifier when disabled#2700
Merged
Conversation
gpbl
approved these changes
Mar 8, 2025
gpbl
left a comment
gpbl
left a comment
Owner
There was a problem hiding this comment.
That’s great! I have no idea why we accepted that previous behavior. 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #2699 by always applying the
selectedmodifier if a day is part of theselecteddate.Notes:
This fix reverts this change from a previous fix PR.
What I understood from the context is that the main issue the referred PR fixes is that the disabled days were able to be clicked and selected, so displaying them as
selectedseems correct while ignoring click events coming from them.Demo:
Tested rendering duplicated
DayPickers by rendering themdisabled.Added new example for testing the modifier customizations are applied: