fix: ensure final week renders when endMonth clips the calendar#2856
Merged
fix: ensure final week renders when endMonth clips the calendar#2856
endMonth clips the calendar#2856Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported by @Toni997 where, when
endMonthis set, the final month’s last week is truncated and missing the remaining table cells. The fix ensures the grid still renders through the end of that week while respecting theendMonthconstraint.Changes
Breaking change note
No public API changed, so semver-wise it’s a bugfix (patch) rather than a breaking/major change. We should however note in the changelog that the last month with
endMonthnow renders a full final week row; consumers with brittle DOM/snapshot/visual tests or custom CSS might see diffs and need to update snapshots/styles.Result
Empty table cells are rendered in the last week: