Merged
Conversation
🦋 Changeset detectedLatest commit: ec25c63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Moves the
amETlocale implementation into@daypicker/ethiopicand removes theamETexport from the mainreact-day-picker/localebarrel.Also updates the v10 Ethiopic docs and upgrading guide to point
amETconsumers to@daypicker/ethiopic, adds a package entry-point test for the locale export, and includes a changeset forreact-day-pickerand@daypicker/ethiopic.Review Notes
This keeps the Ethiopic-specific locale owned by the Ethiopic calendar package while leaving the generic shared locale re-exports alone.
Validation run locally:
pnpm exec jest --selectProjects packages packages/ethiopic/src/locale/am-ET.test.ts packages/ethiopic/src/index.test.ts packages/ethiopic/src/ethiopic/index.test.tsxpnpm --filter react-day-picker run buildpnpm --filter @daypicker/ethiopic run buildpnpm --filter website run typecheckpnpm --filter website run buildpnpm lintpnpm typecheck