Skip to content

The configuration skip should affect all goals #628

Open
@klopfdreh

Description

@klopfdreh

Describe the bug
I just tested it with native-maven-plugin (0.10.3), but I assume it is the same for the gradle plugin which should be checked.

You can apply configuration tag to executions and for the plugin in general. When applied to the plugin in general there should be a way to disable all goals which implies the tag skip at this level

Example:

<plugin>
    <groupId>org.graalvm.buildtools</groupId>
    <artifactId>native-maven-plugin</artifactId>
    <version>0.10.3</version>
    <configuration>
        <metadataRepository>
            <enabled>true</enabled>
        </metadataRepository>
        <requiredVersion>22.3</requiredVersion>
        <skip>true</skip>
    </configuration>
    <executions>
        <execution>
            <id>add-reachability-metadata</id>
            <goals>
                <goal>add-reachability-metadata</goal>
            </goals>
        </execution>
    </executions>
</plugin>

The goal add-reachability-metadata in this case is not skipped at all.

To Reproduce
Create a project with native-maven-plugin and apply skip to the configuration of the plugin.

Expected behavior
If you apply skip to the root configuration all goals should be disabled. add-reachability-metadata is executed anyway.

Logs
N/A

System Info (please complete the following information):

  • OS: Mac
  • GraalVM Version 22.3
  • Java Version 18
  • Plugin version native-maven-plugin:0.10.3

Additional context

My suggestion would to have a property for each goal to disable / enable it separately - e.g. <skipAddReachabilityMetaData> / <skipNativeBuild> / ... and one property to disable all at once <skip> at root level configuration tag.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions