Add Macaron checks for GitHub Actions workflows#865
Open
vjovanov wants to merge 2 commits intograalvm:masterfrom
Open
Add Macaron checks for GitHub Actions workflows#865vjovanov wants to merge 2 commits intograalvm:masterfrom
vjovanov wants to merge 2 commits intograalvm:masterfrom
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
vjovanov
force-pushed
the
vj/issue-864-macaron-checks
branch
from
444e0a2 to
1fadfd9
Compare
vjovanov
commented
Apr 7, 2026
vjovanov
commented
Apr 7, 2026
vjovanov
force-pushed
the
vj/issue-864-macaron-checks
branch
from
2625c5a to
9d290c7
Compare
behnazh-w
reviewed
Apr 8, 2026
behnazh-w
left a comment
behnazh-w
left a comment
There was a problem hiding this comment.
To help Dependabot bumping the version and improve readability, it is a common practice to add the version string as a comment next to the commit SHA. I have added version strings in my comments wherever missing.
| steps: | ||
| - name: "🔧 Install Gradle JDK (JDK${{ inputs.java-version }})" | ||
| uses: actions/setup-java@v4 | ||
| uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 |
There was a problem hiding this comment.
To help Dependabot bumping the version and improve readability, it is a common practice to add the version string as a comment next to the commit SHA.
Suggested change
| uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 | |
| uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # v4 |
| steps: | ||
| - name: "☁ Checkout repository" | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | |
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 |
| steps: | ||
| - name: "☁️ Checkout repository" | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | |
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 |
| - name: "📜 Upload tests results" | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | |
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 |
| steps: | ||
| - name: "☁️ Checkout repository" | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | |
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 |
| - name: "📜 Upload functional tests results" | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | |
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 |
| run: ./gradlew :native-gradle-plugin:test :native-gradle-plugin:inspections | ||
| - name: "📜 Upload unit test results" | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | |
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 |
| - name: "📜 Upload functional tests results" | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | |
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 |
| - name: "📜 Upload unit test results" | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | |
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 |
| - name: "📜 Upload functional tests results" | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 |
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 | |
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Fixes #864