feature: extract label matchers from the prometheus-rules labels #3175
+134
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
feat-add-extra-query-matcher-extraction-from-label
branch
from
41dce1e to
afc3668
Compare
|
|
dehaansa
reviewed
Apr 3, 2025
docs/sources/reference/components/mimir/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
|
By the way, do you think it would make sense to add this feature (extraQueryMatchers) to loki.rules.kubernetes as well? Do you think adding a Boolean (is_structrued_metadata) would work? |
docs/sources/reference/components/mimir/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
thampiotr
reviewed
Apr 7, 2025
docs/sources/reference/components/mimir/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
docs/sources/reference/components/mimir/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
4 tasks
docs/sources/reference/components/mimir/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/mimir/mimir.rules.kubernetes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
approved these changes
Apr 16, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request introduces enhances the
mimir.rules.kubernetescomponent by adding extra label matchers to queries and improving the validation logic. Additionally, it includes updates to the test cases to cover these new functionalities.Which issue(s) this PR fixes
Fixes #3172
Notes to the Reviewer
I tried to implement the field selector approach in the component but I could not really see how it can work. Considering the only fields that would be useful are the rule name, namespace, labels and annotations, maybe we should add a valueFromName,valueFromNamespace and valueFromAnnotation instead of a field selector?
PR Checklist