fix: solve test flakiness in database_observability sample collectors #5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| require.Contains(t, logBuffer.String(), tc.errorLine) | ||
| }, 5*time.Second, 100*time.Millisecond) | ||
| }, 10*time.Second, 200*time.Millisecond) |
Contributor
There was a problem hiding this comment.
I forgot to mention that I went through these tests in #4991, changing the code around expectations on log lines to try to fix the flakyness - don't think we need to increase timeouts here.
Contributor
Author
There was a problem hiding this comment.
No need for this PR then?
Contributor
There was a problem hiding this comment.
Probably not, I haven't seen other flaky occurrences. However I see you changed query_samples.go as well, and seems your update might fix a leak of the runSetupConsumersCheck goroutine? If so, maybe that specific change could be reviewed in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixing some flaky tests by:
Increasing the time threshold for eventually checks.
Adding Waitgroups for better routine handlling.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist