Skip to content

Support disabling post-formatting in Go jenny #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Mar 28, 2025

If the generated Go code isn't valid, post-formatting will fail and prevent the code from being written to disk.

To make debugging these cases easier, this PR adds an option to disable this formatting.

@K-Phoen K-Phoen self-assigned this Mar 28, 2025
@K-Phoen K-Phoen requested a review from a team as a code owner March 28, 2025 15:18
@K-Phoen
Copy link
Member Author

K-Phoen commented Mar 28, 2025

The tests are failing because of a broken schema for the next version of Grafana

@K-Phoen K-Phoen force-pushed the go/configurable-post-formatting branch from 0e58cc2 to 667af4c Compare March 31, 2025 11:43
Copy link

Note: the diff show code changes that would be introduced by this PR to the output of the config/foundation_sdk.dev.yaml codegen pipeline (dev version of the Foundation SDK).

🔎 Changes to config/foundation_sdk.dev.yaml

@K-Phoen K-Phoen merged commit 050cc32 into main Mar 31, 2025
10 checks passed
@K-Phoen K-Phoen deleted the go/configurable-post-formatting branch March 31, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants