-
Notifications
You must be signed in to change notification settings - Fork 3
Fix PHP jsonSerialize() methods to return correct outputs for empty objects #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the diff show code changes that would be introduced by this PR to the output of the
config/foundation_sdk.dev.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing data in an array in
jsonSerialize()
methods is convenient, but it has the nasty side-effect of not allowing thejson_encode()
function to distinguish between empty arrays and empty objects. Both get encoded as[]
.For example, we get the following error when validating a dashboard that doesn't have annotations:
That's because within the generated dashboard JSON, the
annotations
field is defined as"annotations": []
instead of"annotations": {}
.This PR fixes that issue by storing the data in a
stdClass
object, so that even if they're emptyjson_encode()
will know to encode them as objects.