Change release to trigger on version change #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwcyu
approved these changes
Apr 24, 2023
kevinwcyu
reviewed
Apr 24, 2023
| if: steps.version_check.outputs.changed == 'true' | ||
| run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
i don't actually see a GITHUB_TOKEN in this repo's settings. do we need to add that
There was a problem hiding this comment.
The GITHUB_TOKEN is a temporary secret that is created at runtime and has certain limited permissions, so we don't need to explicitly add it. I think this should be ok without giving it any specific permissions for this action🤞🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the release step to trigger on every commit to main with a version change.
Basically copied the steps from grafana/aws-sdk-react, and replaced the github release step from the old publish as a separate job. Lmk if it looks good