Better error message checking #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we check exactly matching of error message return by go standard library. It's working nowaday but not guaranteed to work in upcoming go version. At least in go1.14, all the certificate expried message checking test will fail, due to the change of error message format in net/http. To fix this, we only check that error message contains the message we want, e.g certificate expired error should contain word "expired". While at it, also add some require.NoError to make sure no editor complains above "can lead to nil pointer dereference".
cuonglm
force-pushed
the
cuonglm/refactoring-error-message-check-in-test
branch
from
9306558 to
7c9ded2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
=========================================
+ Coverage 75.28% 75.3% +0.01%
=========================================
Files 149 149
Lines 10841 10841
=========================================
+ Hits 8162 8164 +2
+ Misses 2212 2210 -2
Partials 467 467
Continue to review full report at Codecov.
|
mstoykov
previously approved these changes
Nov 18, 2019
You mean this golang/go#34066? |
na--
approved these changes
Nov 18, 2019
mstoykov
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we check exactly matching of error message return by go
standard library. It's working nowaday but not guaranteed to work in
upcoming go version. At least in go1.14, all the certificate expried
message checking test will fail, due to the change of error message
format in net/http.
To fix this, we only check that error message contains the message we
want, e.g certificate expired error should contain word "expired".
While at it, also add some require.NoError to make sure no editor
complains above "can lead to nil pointer dereference".