[Binary provisioning] Move Launcher to internal/cmd package #4712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It merges the launcher package into
internal/cmd.Why?
At the moment, k6 isn't designed to have a separate package for startup ops, and doing so was causing problems. So, as we want to avoid major refactoring, then it necessitates adhering to this structure.
This is especially important for the config, which is internal to the 'cmd' package. While exporting a dedicated 'config' package would be beneficial, it would require significant time and effort. For now, maintaining the current structure will be simple, and simplicity is key here.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)