feat: bookmarks sidebar #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1767e9a.
shelldandy
commented
Apr 16, 2025
| @@ -5,5 +5,5 @@ export default config({ | |||
| reporter: [['list'], ['html', { outputFolder: '../test-reports', open: 'never' }], ['github']], | |||
| retries: 1, | |||
| forbidOnly: true, | |||
| workers: 1, | |||
| workers: 2, | |||
There was a problem hiding this comment.
gotta go fast, but in CI :)
|
miguel this is really good!! looks like bookmarks are being stored correctly in the sidebar. my main feedback is that it seems clicking on a bookmark doesn't take me to the metric the rest of my feedback is non-blocking nits:
277.toast-notif.mov277.scrollbar-persist.mov
|
|
clicking on a bookmark now takes me to the bookmarked metric - nice!! ❤️ i noticed a few other things. since i think the MVP functionality of bookmarks has been met (ability to bookmark, click on a bookmark and see the metric), i think these things can be addressed in the future. WDYT?
277.filters-on-top-after-bookmarking.mov
277.clicking-on-bookmark-no-star.mov
277.cross-DS-bookmarks.mov |
yangkb09
previously approved these changes
Apr 23, 2025
|
This looks good! Two small nits:
|
|
re:
This was my bad! Fixed by #326. |
NWRichmond
previously approved these changes
Apr 23, 2025
Co-authored-by: Nick Richmond <[email protected]> Signed-off-by: Miguel Palau <[email protected]>
NWRichmond
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #253
Empty: