Skip to content

feat(scopes): add ScopesBridge #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(scopes): add ScopesBridge #288

wants to merge 2 commits into from

Conversation

tskarhed
Copy link

@tskarhed tskarhed commented Apr 14, 2025

✨ Description

Related issue(s):

Closes #45

Enables Scopes usage. Inspiration taken from https://github.com/grafana/grafana/pull/97176/files#diff-ad37fab92c3cc711f1ba8ce84693e7c07543a93aaba842d1cc925d3bd6531b57

📖 Summary of the changes

  • Instantiates a new ScopesBridge
  • Use the ScopesBridge to enable the topbar
  • Use ScopesBirdge to get scopes when making queries. This can't be done automatically, as the app is not structured around scenes.

🧪 How to test?

Enable feature flags and click around

@NWRichmond
Copy link
Collaborator

@tskarhed with respect to:

Use ScopesBirdge to get scopes when making queries. This can't be done automatically, as the app is not structured around scenes.

I'm assuming this refers to not using SceneApp, which wraps its own ScopesBridge? If so, I'll make note that we'll remove the ScopesBridge added here if we ever make the transition to SceneApp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore Scopes functionality once Scopes is available in grafana packages
2 participants