fix: avoid panic in init godeltaprof/http/pprof for go 1.23 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
changed the title
cristiangreco
added a commit
to grafana/dskit
that referenced
this pull request
Aug 23, 2024
While godeltaprof v0.1.7 fixed a build issue with go1.23, version v0.1.8 fixes a runtime error. See grafana/pyroscope-go#119
cristiangreco
added a commit
to grafana/dskit
that referenced
this pull request
Aug 26, 2024
While godeltaprof v0.1.7 fixed a build issue with go1.23, version v0.1.8 fixes a runtime error. See grafana/pyroscope-go#119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #118
go 1.23 changed the way
net/http/pprofregisters pprof endpoints by prefixing with"GET "This leads to panics if godeltaprof does not do the same.
https://github.com/golang/go/blob/9fcffc53593c5cd103630d0d24ef8bd91e17246d/src/net/http/pprof/pprof.go#L98-L97
golang/go@9fcffc5