Skip to content

Comma separated string in tag causes panic #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kbumsik opened this issue Apr 16, 2025 · 0 comments · May be fixed by #213
Open

Comma separated string in tag causes panic #210

kbumsik opened this issue Apr 16, 2025 · 0 comments · May be fixed by #213
Assignees
Labels
bug Something isn't working

Comments

@kbumsik
Copy link

kbumsik commented Apr 16, 2025

Setting "0,1,2,3" for tags causes pinc.

For example,

pyroscope.configure(
    application_name="Test",
    server_address="http://localhost:4040",
    detect_subprocesses=True,
    oncpu=True,
    gil_only=False,
    tags={
        "slurm_step_gpus": "0,1,2,3",
    },
)

I got the following error:

thread '<unnamed>' panicked at pyroscope_ffi/python/lib/src/lib.rs:288:38:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at core/src/panicking.rs:221:5:
panic in a function that cannot unwind
stack backtrace:
   0:     0x709703310ce9 - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h304520fd6a30aa07
   1:     0x70970306222b - core::fmt::write::hf5713710ce10ff22
   2:     0x7097032e3f12 - std::io::Write::write_fmt::hda708db57927dacf
   3:     0x709703311ee8 - std::panicking::default_hook::{{closure}}::he1ad87607d0c11c5
   4:     0x709703312d9d - std::panicking::rust_panic_with_hook::had2118629c312a4a
   5:     0x709703312852 - std::panicking::begin_panic_handler::{{closure}}::h7fa5985d111bafa2
   6:     0x7097033127e9 - std::sys::backtrace::__rust_end_short_backtrace::h704d151dbefa09c5
   7:     0x7097033127d4 - rust_begin_unwind
   8:     0x70970300ce04 - core::panicking::panic_nounwind_fmt::hc0ae93930ea8f76c
   9:     0x70970300ce6c - core::panicking::panic_nounwind::h9f485ff9b02bac75
  10:     0x70970300ce19 - core::panicking::panic_cannot_unwind::hea865182d7ce50af
  11:     0x70970303078e - initialize_agent
  12:     0x709703b4e052 - ffi_call_unix64
  13:     0x709703b4c3dc - ffi_call_int
  14:     0x709703b4a3c7 - cdata_call
                               at /project/cffi/src/c/_cffi_backend.c:3229:5
  15:     0x5b859adf09ab - _PyObject_MakeTpCall
                               at /usr/local/src/conda/python-3.12.2/Objects/call.c:240:18
  16:     0x5b859acf4a7e - _PyEval_EvalFrameDefault
                               at /home/conda/feedstock_root/build_artifacts/python-split_1708115583107/work/build-static/Python/bytecodes.c:2706:19
  17:     0x5b859aebbcae - PyEval_EvalCode
                               at /usr/local/src/conda/python-3.12.2/Python/ceval.c:578:21
  18:     0x5b859aedf45a - run_eval_code_obj
                               at /usr/local/src/conda/python-3.12.2/Python/pythonrun.c:1722
  19:     0x5b859aedaacb - run_mod
                               at /usr/local/src/conda/python-3.12.2/Python/pythonrun.c:1743
  20:     0x5b859aef1230 - pyrun_file
                               at /usr/local/src/conda/python-3.12.2/Python/pythonrun.c:1643
  21:     0x5b859aef0e0e - _PyRun_SimpleFileObject
                               at /usr/local/src/conda/python-3.12.2/Python/pythonrun.c:433
  22:     0x5b859aef0684 - _PyRun_AnyFileObject
                               at /usr/local/src/conda/python-3.12.2/Python/pythonrun.c:78
  23:     0x5b859aeea6b2 - pymain_run_file_obj
                               at /usr/local/src/conda/python-3.12.2/Modules/main.c:360
  24:     0x5b859aeea6b2 - pymain_run_file
                               at /usr/local/src/conda/python-3.12.2/Modules/main.c:379
  25:     0x5b859aeea6b2 - pymain_run_python
                               at /usr/local/src/conda/python-3.12.2/Modules/main.c:629
  26:     0x5b859aeea6b2 - Py_RunMain
                               at /usr/local/src/conda/python-3.12.2/Modules/main.c:709
  27:     0x5b859aea6217 - Py_BytesMain
                               at /usr/local/src/conda/python-3.12.2/Modules/main.c:763:12
  28:     0x709703c29d90 - <unknown>
  29:     0x709703c29e40 - __libc_start_main
  30:     0x5b859aea6095 - <unknown>
thread caused non-unwinding panic. aborting.
/var/lib/slurm/slurmd/job00813/slurm_script: line 15: 2091866 Aborted                 (core dumped) python hello.py
@kbumsik kbumsik added the bug Something isn't working label Apr 16, 2025
@korniltsev korniltsev self-assigned this Apr 16, 2025
@korniltsev korniltsev linked a pull request Apr 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants