-
Notifications
You must be signed in to change notification settings - Fork 668
Open
Labels
Description
We're currently using the HTTP interface exclusively:
pyroscope/pkg/objstore/providers/gcs/bucket_client.go
Lines 20 to 34 in 1420455
func NewBucketClient(ctx context.Context, cfg Config, name string, logger log.Logger) (objstore.Bucket, error) { | |
bucketConfig := gcs.Config{ | |
Bucket: cfg.BucketName, | |
ServiceAccount: cfg.ServiceAccount.String(), | |
HTTPConfig: exthttp.HTTPConfig{ | |
IdleConnTimeout: model.Duration(cfg.HTTP.IdleConnTimeout), | |
ResponseHeaderTimeout: model.Duration(cfg.HTTP.ResponseHeaderTimeout), | |
InsecureSkipVerify: cfg.HTTP.InsecureSkipVerify, | |
TLSHandshakeTimeout: model.Duration(cfg.HTTP.TLSHandshakeTimeout), | |
ExpectContinueTimeout: model.Duration(cfg.HTTP.ExpectContinueTimeout), | |
MaxIdleConns: cfg.HTTP.MaxIdleConns, | |
MaxIdleConnsPerHost: cfg.HTTP.MaxIdleConnsPerHost, | |
MaxConnsPerHost: cfg.HTTP.MaxConnsPerHost, | |
}, | |
} |
We should explore the GCS gRPC API option:
simonswine