-
Notifications
You must be signed in to change notification settings - Fork 717
docs: ebpf-otel fixes #3777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ebpf-otel fixes #3777
Conversation
|
This PR must be merged before a backport PR will be created. |
2 similar comments
|
This PR must be merged before a backport PR will be created. |
|
This PR must be merged before a backport PR will be created. |
knylander-grafana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the readmes and the examples. Approving the readme changes.
marcsanmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
| RUN wget https://go.dev/dl/go1.22.10.linux-amd64.tar.gz | ||
| RUN tar -C /usr/local -xzf go1.22.10.linux-amd64.tar.gz | ||
| # fixed versions for pyroscope, otel-collector, otel-profiler due to protocol changes | ||
| RUN wget https://github.com/open-telemetry/opentelemetry-ebpf-profiler/archive/9eb454541a3cf1282a8755dbcec9a9471b243e83.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. However, I think we should update to avoid working with pinned versions and images once the profiler is stable enough
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3777-to-release/v1.9 origin/release/v1.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x a2c06eeb4719429993c82a486c94a86785161d1cWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3777-to-release/v1.9
# Create the PR body template
PR_BODY=$(gh pr view 3777 --json body --template 'Backport a2c06eeb4719429993c82a486c94a86785161d1c from #3777{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.9] docs: ebpf-otel fixes' --body-file - --label 'type/docs' --label 'backport' --base release/v1.9 --milestone release/v1.9 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3777-to-release/v1.9
# Create a pull request where the `base` branch is `release/v1.9` and the `compare`/`head` branch is `backport-3777-to-release/v1.9`.
# Remove the local backport branch
git switch main
git branch -D backport-3777-to-release/v1.9 |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3777-to-release/v1.10 origin/release/v1.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x a2c06eeb4719429993c82a486c94a86785161d1cWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3777-to-release/v1.10
# Create the PR body template
PR_BODY=$(gh pr view 3777 --json body --template 'Backport a2c06eeb4719429993c82a486c94a86785161d1c from #3777{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.10] docs: ebpf-otel fixes' --body-file - --label 'type/docs' --label 'backport' --base release/v1.10 --milestone release/v1.10 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3777-to-release/v1.10
# Create a pull request where the `base` branch is `release/v1.10` and the `compare`/`head` branch is `backport-3777-to-release/v1.10`.
# Remove the local backport branch
git switch main
git branch -D backport-3777-to-release/v1.10 |
Notes: ebpf profiler does not properly work in minikube. I've tested in a real k8s cluster by pushing an image to the public docker repo. I am not sure we should advertise minikube in the example if it does not work. We can consider submiting a PR with pid namespace inspection from pyroscope ebpf profiler.