fix(v2): compaction-worker temp directory cleanup #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
commented
Jan 16, 2025
Comment on lines
+376
to
+380
| defer func() { | ||
| if err = os.RemoveAll(tempdir); err != nil { | ||
| level.Warn(logger).Log("msg", "failed to remove compaction directory", "path", tempdir, "err", err) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Although the content is removed, the job directory isn't
korniltsev
approved these changes
Jan 16, 2025
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compaction-worker does not cleanup the directory it uses for "staging" (kind of temp).
Typically, this is not a problem, because the intermediate data is deleted during the compaction process. However, the disk space (including ephemeral volumes) might be exhausted in case if the compactor fails to finish the compaction.