fix: Update minio-go to fix bug in AWS STS auth #4056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
added
type/bug
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
With the upgrade of objstore libraries from grafana#3954 we introduced bug This fixes the underlying problem and adds a tests to validate that form of auth.
simonswine
force-pushed
the
20250326_s3-auth-issue
branch
from
b9a5bee to
3078277
Compare
kolesnikovae
approved these changes
Mar 27, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4056-to-release/v1.12 origin/release/v1.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0d4abec3875dde22b5c4255a0a4c56f81d1ec79aWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-4056-to-release/v1.12
# Create the PR body template
PR_BODY=$(gh pr view 4056 --json body --template 'Backport 0d4abec3875dde22b5c4255a0a4c56f81d1ec79a from #4056{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.12] fix: Update minio-go to fix bug in AWS STS auth' --body-file - --label 'type/bug' --label 'backport' --base release/v1.12 --milestone release/v1.12 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-4056-to-release/v1.12
# Create a pull request where the `base` branch is `release/v1.12` and the `compare`/`head` branch is `backport-4056-to-release/v1.12`.
# Remove the local backport branch
git switch main
git branch -D backport-4056-to-release/v1.12 |
|
Thanks for the fixing this! I build a container image from this PR (ghcr.io/sberz/pyroscope:20250326_s3-auth-issue-3cf63125c) and deployed it to our development environment. |
simonswine
added a commit
that referenced
this pull request
Mar 27, 2025
* fix: Update minio-go to fix bug in AWS STS auth With the upgrade of objstore libraries from #3954 we introduced bug This fixes the underlying problem and adds a tests to validate that form of auth. * lint * Be more specific about the format (cherry picked from commit 0d4abec) Co-authored-by: Christian Simon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade of objstore libraries from #3954 we introduced a bug #4050.
This fixes the underlying problem and adds a tests to validate that form of auth.