Skip to content

Remove the redshiftAsyncQuerySupport feature toggle + styling improvements #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

idastambuk
Copy link
Contributor

@idastambuk idastambuk commented Mar 12, 2024

Same as grafana/athena-datasource#316

Did a few things here:

  • remove the redshiftAsyncQuerySupport feature toggle
  • removed the use of deprecated width-30 class to instead use Grafana theme spacing
  • fixed the Run query button to not be disabled if there is no change in the editor. I was kinda bothered by this cause I sometimes just wanted to rerun the same query and not have to go all the way up to the Grafana dashboard refresh button. Also I realized this is how Cloudwatch header buttons work - the Run button is never disabled

I thought the changes were small enough to squeeze in here, but lmk if you'd rather I separate them into 2 or 3 PRs.

@idastambuk idastambuk requested a review from a team as a code owner March 12, 2024 13:34
@idastambuk idastambuk requested review from iwysiu and kevinwcyu March 12, 2024 13:34
@idastambuk idastambuk changed the title Remove toggle Draft: Remove toggle Mar 12, 2024
@idastambuk idastambuk changed the title Draft: Remove toggle Remove the redshiftAsyncQuerySupport feature toggle + styling improvements Mar 18, 2024
Co-authored-by: Kevin Yu <[email protected]>
@idastambuk idastambuk merged commit ed48ca0 into main Mar 19, 2024
4 checks passed
@idastambuk idastambuk deleted the asyncquerydata-toggle branch March 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants